Username dots path traversal - #1634
Open
vmo69 wants to merge 2 commits into
Open
Conversation
vmo69
force-pushed
the
username_dots_path_traversal
branch
from
September 10, 2026 10:49
797f74e to
b4a9978
Compare
sirainen
requested changes
Sep 10, 2026
| databases. | ||
|
|
||
| If you want to allow all characters, leave the value empty.` | ||
| If you want to allow all characters, leave the value empty. |
Contributor
There was a problem hiding this comment.
-
Duplicate heading. 2.4-to-2.4.x.md already has ### v2.4.5 to v2.4.6 above the four existing
2.4.6 includes. New include must go under it, not new heading. -
data/updates.js not touched. Convention: add keys (e.g. auth_username_dots_rejected:
'2.4.6', settings_mail_path_confined: '2.4.6') and use changed: { key: ... } blocks on
auth_username_chars, mail_home, mail_path, index/cache/control/alt paths instead of plain text
appends. -
documentation-pro: no branch. Needs data/updates.js (3.3.0), settings.js changes.
-
Wording nits in 2.4.6-path-traversal.inc
- "never valid RFC 5322 addresses": usernames need not be addresses. Say "cannot exist as
directory names". - Add: templates starting with ~/ or %{home} have no literal prefix and are only normalized.
- If finding 1 (in core MR) stays as is, state that an empty trailing variable is rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOV-9793